Build with ocicl instead of git submodules (first-pass)#3661
Draft
logoraz wants to merge 1 commit intoatlas-engineer:masterfrom
Draft
Build with ocicl instead of git submodules (first-pass)#3661logoraz wants to merge 1 commit intoatlas-engineer:masterfrom
logoraz wants to merge 1 commit intoatlas-engineer:masterfrom
Conversation
- First pass at incorporating ocicl into build (needs refinement) - Update makefile replacing submodules flag with ocicl flag - Updated gitignore to ignore ocicl directory & registry ocicl.csv - Kept _build directory for later removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a first pass at updating the build process to use ocicl to pull the cl systems needed instead of git submodules.
Opening for review and better visibility to align/clean things up accordingly. Happy to help/assist an any way necessary, just need advisement.
Update makefile to incorporate build with ocicl
Fixes # (issue) - N/A
Checklist:
I have only tested this build with the electron variant as of current - would need assistance checking the below:
(asdf:test-system :nyxt/<renderer>))